Fix/extra parens#124
Conversation
This function takes in a string and only adds `()` when there are no previous parens.
|
Code LGTM 👍 Just wanna verify locally how the generated code changes to be on the safe side 🙂 |
|
Nice, this fixes the bug for aws-erlang as well while you were at it so that's confirmed 🎉 🥇 |
|
I'm testing the build failure for aws-erlang in the PR mentioned above before pushing that change to your branch 👍 Give me a bit of time to sort that one out. |
|
Thank you! I'll have a look as to why OTP 27 was failing s3_SUITE in aws-erlang since it isn't failing in my branch on aws-erlang (see branch) 😕 Will try to figure this out before tagging new releases in aws-elixir and aws-erlang. |
I can't replicate the errors on OTP 27 locally so for now we'll test the aws-codegen for Erlang on OTP 26 👍 I'll pick this up some other day again. |
|
@onno-vos-dev I didn't even think to run each repos tests! Glad this fixed other issues too! |
3 participants
Prior to this change there were cases where extra parenthesis
()would show up and you could see double parenthesis()().I don't think this affects Erlang, but not 100%.
The only test that is fail is this one: